Rename some functions in fuzzer.rs #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Jul 1, 2024
| @@ -411,7 +411,7 @@ where | |||
| where | |||
| EM: EventFirer<State = Self::State>, | |||
| { | |||
| let exec_res = self.execute_no_process(state, manager, &input, observers, exit_kind)?; | |||
| let exec_res = self.check_results(state, manager, &input, observers, exit_kind)?; | |||
| let corpus_id = self.process_execution( | |||
There was a problem hiding this comment.
Shouldn't this guy be evaluate_execution?
There was a problem hiding this comment.
evaluate_execution is already used. actually it's wrapping this
evaluate_execution have two wrapped functions
check_results: to see if the testcase is obj or corpus and
process_execution: append metadatas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions have really strange names.
execute_no_process doesn't execute anything.
execute_and_process doesn't execute anything either.
i just rename it to make them have proper names