Change Corpus Pruning algorithm #2418
Conversation
| corpus.add_disabled(removed)?; | ||
| } | ||
| for (idx, testcase) in enabled_to_disabled { | ||
| state.corpus_mut().add_disabled(testcase)?; |
There was a problem hiding this comment.
I don't think we should ever allow a call to call add(_disabled) with a testcase that's already added, we should have a set_enabled(true/false) method instead
There was a problem hiding this comment.
it seems counter-intuitive as API, and it will hide bugs where we add them twice by accident
There was a problem hiding this comment.
but this testcase is not "already added" at this point of execution, because we just removed it a few lines before.
There was a problem hiding this comment.
we should have a set_enabled(true/false) method instead
yes i know.
but if we will implement it, then internally it would look the same as this. because disabled and enabled have separate corpus. if you want move them, then the only way is (i guess) to delete from one and then add to the other
No description provided.