Fix cmplog implementation #2439
Conversation
only set testcase filepath if filepath is none
|
Ah probably need to also accomodate |
|
Note: the no_std CI failure has nothing to do with this PR |
fix extended_cmplog_instrumentation
libafl_targets/src/cmps/mod.rs
Outdated
| // other => panic!("Invalid CmpLog shape {}", other), | ||
| _ => None, | ||
| } | ||
| } | ||
| } else { | ||
| unsafe { | ||
| let v0_len = self.vals.fn_operands[idx][execution].v0_len & (0x80 - 1); |
There was a problem hiding this comment.
why you don't look at len anymore?
There was a problem hiding this comment.
From my understanding, this was only necessary due to the length of the v1/v0 array being 31 instead of 32 right?
There was a problem hiding this comment.
hmm no.
sometimes each fn operands has its length (not necessarily 32). so you should keep the length
There was a problem hiding this comment.
Also, random question, could we get around the allocation here?
There was a problem hiding this comment.
not possible.
the tokens have to be copied from the shared mem. else it'll be overwritten in the next round
There was a problem hiding this comment.
But they could be copied to a preexisting buffer
There was a problem hiding this comment.
but we don't know how many of them needs buffer so we can't decide its size.
There was a problem hiding this comment.
It's only up to 64 bytes, so we could just always have 64 bytes extra?
There was a problem hiding this comment.
Like, just memcpy the existing struct and make a nice accessor around it that returns a slice
|
@R9295 can you fix the length so we can merge? |
only set testcase filepath if filepath is none