Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libafl: Implement FeedbackFactory for {Const,Not}Feedback #2478

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

dergoegge
Copy link
Contributor

It is currently not possible to use a NotFeedback or ConstFeedback (or a combination thereof) for a StdTMinMutationalStage, because both of these feedback types do not implement FeedbackFactory.

This PR implements FeedbackFactory for both.

@domenukk
Copy link
Member

domenukk commented Aug 8, 2024

Thank you!

@addisoncrump is it ok if we merge this right now or should we wait?

@domenukk domenukk requested a review from addisoncrump August 8, 2024 12:35
Copy link
Collaborator

@addisoncrump addisoncrump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domenukk domenukk merged commit 799c634 into AFLplusplus:main Aug 9, 2024
48 of 99 checks passed
dergoegge added a commit to dergoegge/LibAFL that referenced this pull request Aug 14, 2024
* libafl: Impl FeedbackFactory for NotFeedback

* libafl: Impl FeedbackFactory for ConstFeedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants