Custom QEMU emulator typed builder + ExitHandler / Commands refactoring #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rmalmain
commented
Aug 14, 2024
rmalmain
commented
- Add a typed builder for Emulator
- Update tuple to support Prepend / Append in the same way
- Unify qemu_init for usermode and systemmode
- Remove env from qemu init args (it is unused in QEMU in practice)
* Update tuple to support Prepend / Append in the same way * Unify qemu_init for usermode and systemmode * Remove env from qemu init args (it is unused in QEMU in practice)
* add build function
* Reorder generics alphabetically for Qemu{,Fork}Executor
* Started to adapt qemu_systemmode breakpoint example with new builder (WIP)
* Moved snapshot manager to Emulator to continue centralizing mains objects in the same structure
* Remove many IsCommand generics
* Reimplementation of CommandManager working with enums instead of vtables
* Macro has been adapted to do this work automatically
* Moved snapshot stuff to dedicated module
* Removed many Rc<RefCell<...>>, now useless with the removal of vtables
TODO:
* Finish Drivers trait implementations
* Better handling of breakpoints (for now there are many clones)
*
rmalmain
changed the title
|
TODO:
|
domenukk
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.