libafl multimachine: disable ratelimiting #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rate limiting should be on the sender side, IMHO |
hum not sure about this, a child doesn't know how many other children there are for a given parent, so it cannot (apriori) know what rate limit to choose statically. |
|
just a global setting "don't send more often than every x millis" is fine |
rmalmain
added a commit
that referenced
this pull request
Oct 7, 2024
* disable rate limiting for now * fix * clippy --------- Co-authored-by: Dongjia "toka" Zhang <tokazerkje@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally there was a (primitive) rate limiter in case a lot of testcases were received by a node at once.
this caused the buffer to not be emptied fast enough on some targets when inputs are heavy.
i will refactor rate limiting if it happens to be necessary later on, for now it should not cause any problem to disable it.