libafl-fuzz: separate frida build + cmplog debug #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R9295
changed the title
|
https://github.com/mxschmitt/action-tmate use this if you want to connect to their vm |
move time_tracker stage to LibAFL
|
Since AFL++ runs the timeout again with double the timeout, to confirm if it is actually a timeout, I'll implement that and check if that fixes the CI |
R9295
commented
Oct 8, 2024
tokatoka
reviewed
Oct 8, 2024
tokatoka
reviewed
Oct 8, 2024
|
you can delete old afl_stat.rs |
domenukk
reviewed
Oct 9, 2024
…ecutor libafl-fuzz: add verify_timeout stage
|
Making this into a draft PR cause still a bit WIP |
|
|
domenukk
reviewed
Oct 24, 2024
| } | ||
| } | ||
|
|
||
| impl<E, EM, Z, S> Stage<E, EM, Z> for VerifyTimeoutsStage<E, S> |
There was a problem hiding this comment.
This can go in the main lib as well, right? Or is it forkserver specific?
There was a problem hiding this comment.
@domenukk executors must implement HasTimeout for this and currently, not many have. But we can move it to the main lib
domenukk
reviewed
Oct 24, 2024
| ) -> Result<(), Error> { | ||
| let mut timeouts = state | ||
| .metadata_or_insert_with(TimeoutsToVerify::<<S::Corpus as Corpus>::Input>::new) | ||
| .clone(); |
There was a problem hiding this comment.
@domenukk fuzzer.evaluate_input wants an owned input and not a reference
There was a problem hiding this comment.
Aah, sad.
Anyway, the loop below will only work for forkserver, never for inprocess, right?
There was a problem hiding this comment.
Maybe add a TODO note for ppl in the future noting this
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Dec 11, 2024
* libafl-fuzz: separate frida build * cmplog debug * update * merge AflStatsStage move time_tracker stage to LibAFL * mandate track_hit_feedbacks feature for AflStatsStage * afl_stats do not hardcode TimeoutFeedback and CrashFeedback names * typo * typo * fix generics order * add verify timeouts stage * libafl: introduce set_timeout func to dynamically set timeouts for executor libafl-fuzz: add verify_timeout stage * add missing set_timeout implementations * libafl-fuzz: move set_timeout and timeout from Executor to HasTimeout * libafl-fuzz: add removed gitignore * remove timeout from libafl_nyx::Executor and move it to NyxHelper * clippy * fix HasTimeout for QemuExecutor * libafl-fuzz: remove observer handle usage in verify_timeouts misc: remove prelude imports * libafl-fuzz: fix foreign_sync_dirs option * fmt && clippy * clippy && fmt * missing doc * clippy * bruh * damned doc build * trait fix * impl HasTimeout for InProcessExecutor only if std * clippy * fix typo * fix nostd build * clippy * remove most HasTimeout implementations for now * typo * remove redundant import * misc * fmt * simplify trait bounds * add old AflStatsStage back and rename it to StatsStage * fix ci * make set_timeout and timeout of HasTimeout inline * fmt * add gitignore * serde_any fix * tmate * misc * remove tmate * test * coordinate between capture_timeout and verify_timeout * makefile * fix * fix * fmt * increase cmplog timeout * semantic * debug * debug * remove dbeug * only test libafl-fuzz on CI for now * better seed for cmplog? * remove preflight check for now * set Input type in forkserver * debug * tmate * fix capture_timeout * revert workflow * run only libafl-fuzz * remove pre-flight * re-enable fuzzers on CI * move capture_timeouts and verify_timeouts to main lib * run fmt * add note for verify timeouts * add note in verify timeouts stage * typo --------- Co-authored-by: Dominik Maier <domenukk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the cmplog issue in this pr too