Apple aarch64 fixes #660
Merged
Apple aarch64 fixes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A warning is ok imo |
|
TODO: The |
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 15.38% 15.37% -0.02%
==========================================
Files 144 144
Lines 16852 16860 +8
==========================================
- Hits 2593 2592 -1
- Misses 14259 14268 +9
Continue to review full report at Codecov.
|
khang06
pushed a commit
to khang06/LibAFL
that referenced
this pull request
Oct 11, 2022
* Apple aarch64 fixes * added shmem provider testcase * added method to not ignore cores, removed deprecated core_affinity api * cleaned up set_affinity tests * fixes * fixes * more aarch * apple needs serial tests * disable testcase for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libccrate is potentially broken, see rust-lang/libc#2812 leading to a segfault.Also, aarch64 macOS doesn't support core affinity on a kernel level, so we ignore it, instead of crashing.
(or should we report this error and leave it up to the user? cc @andreafioraldi )