Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/step input were being confused with additional_input #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nalbion
Copy link
Contributor

@nalbion nalbion commented Feb 10, 2024

Pull Request

Description

task/step input were being confused with additional_input

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
agentprotocolai ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2024 1:31pm

@jzanecook
Copy link
Collaborator

Hey @nalbion, can you take a look at the Python SDK? The way it implements the task_handler is by using a Task class, rather than specifying the task_id and task_input in the handler. Perhaps we can change this to match that implementation for more consistency across the repositories?

@hackgoofer
Copy link
Contributor

TaskInput here is any, so you can theoretically include taskID in the any or dict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants