-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Storage API #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
2 times, most recently
from
September 25, 2024 14:31
8d07623
to
709b654
Compare
PBundyra
force-pushed
the
development
branch
from
September 25, 2024 14:31
01a4b53
to
e26ad1c
Compare
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
from
September 25, 2024 14:34
709b654
to
d987a0e
Compare
PTAL @sharabiani @44past4 |
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
from
October 7, 2024 09:56
c42cd4c
to
18a9474
Compare
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
from
October 8, 2024 12:09
f58296d
to
ccfb37f
Compare
sharabiani
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/xpk/templates/pod.yaml is an empty file
sharabiani
approved these changes
Oct 16, 2024
44past4
reviewed
Oct 17, 2024
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
5 times, most recently
from
October 17, 2024 14:27
af04714
to
31ce6d5
Compare
…ommands, add --type validation, reduce number of CRD installations
PBundyra
force-pushed
the
pbundyra-storage-crd
branch
from
October 17, 2024 14:55
31ce6d5
to
fc2daf3
Compare
44past4
approved these changes
Oct 21, 2024
PBundyra
added a commit
that referenced
this pull request
Oct 21, 2024
* Introduce Storage API * Fix Gh CI/CD * Improve getting storages to mount to workload * Improve handling exception while deleting storage * Fix adding necessary args and cluster credentials * Fix storage class, differentiate storage types in create and delete commands, add --type validation, reduce number of CRD installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Tested manually, CI/CD tests in progress