Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Storage API #192

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Introduce Storage API #192

merged 6 commits into from
Oct 21, 2024

Conversation

PBundyra
Copy link
Collaborator

Fixes / Features

  • Creates Storage CRD that allows attaching existing GCS Bucket to workloads

Testing / Documentation

Tested manually, CI/CD tests in progress

  • [ y ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@PBundyra PBundyra requested a review from Obliviour as a code owner September 25, 2024 14:09
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch 2 times, most recently from 8d07623 to 709b654 Compare September 25, 2024 14:31
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch from 709b654 to d987a0e Compare September 25, 2024 14:34
@PBundyra PBundyra changed the title Pbundyra storage crd Introduce Storage API Sep 25, 2024
@PBundyra
Copy link
Collaborator Author

PBundyra commented Oct 1, 2024

PTAL @sharabiani @44past4

@PBundyra PBundyra assigned PBundyra and unassigned PBundyra Oct 1, 2024
@PBundyra PBundyra requested review from 44past4 and sharabiani October 1, 2024 07:50
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch from c42cd4c to 18a9474 Compare October 7, 2024 09:56
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch from f58296d to ccfb37f Compare October 8, 2024 12:09
Copy link
Collaborator

@sharabiani sharabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/xpk/templates/pod.yaml is an empty file

src/xpk/api/storage_crd.yaml Show resolved Hide resolved
src/xpk/commands/storage.py Outdated Show resolved Hide resolved
src/xpk/core/storage.py Outdated Show resolved Hide resolved
src/xpk/core/storage.py Outdated Show resolved Hide resolved
src/xpk/commands/storage.py Outdated Show resolved Hide resolved
src/xpk/commands/storage.py Outdated Show resolved Hide resolved
src/xpk/core/storage.py Outdated Show resolved Hide resolved
src/xpk/parser/storage.py Outdated Show resolved Hide resolved
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch 5 times, most recently from af04714 to 31ce6d5 Compare October 17, 2024 14:27
…ommands, add --type validation, reduce number of CRD installations
@PBundyra PBundyra force-pushed the pbundyra-storage-crd branch from 31ce6d5 to fc2daf3 Compare October 17, 2024 14:55
@PBundyra PBundyra merged commit 73af01e into development Oct 21, 2024
5 of 6 checks passed
@PBundyra PBundyra deleted the pbundyra-storage-crd branch October 21, 2024 09:28
PBundyra added a commit that referenced this pull request Oct 21, 2024
* Introduce Storage API

* Fix Gh CI/CD

* Improve getting storages to mount to workload

* Improve handling exception while deleting storage

* Fix adding necessary args and cluster credentials

* Fix storage class, differentiate storage types in create and delete commands, add --type validation, reduce number of CRD installations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants