Implement info command #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
PBundyra
reviewed
Oct 7, 2024
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
PBundyra
reviewed
Oct 7, 2024
src/xpk/core/kueue.py
Outdated
| curl = 'curl -Lo ./kubectl-kueue https://github.com/kubernetes-sigs/kueue/releases/download/v0.8.1/kubectl-kueue-linux-amd64' | ||
|
|
||
| chmod = 'chmod +x ./kubectl-kueue' | ||
| mv = 'sudo mv ./kubectl-kueue /usr/local/bin/kubectl-kueue' |
There was a problem hiding this comment.
@44past4 Should we assume user will have sudo permissions? WDYT?
PBundyra
reviewed
Oct 7, 2024
PBundyra
reviewed
Oct 7, 2024
PBundyra
reviewed
Oct 7, 2024
PBundyra
reviewed
Oct 7, 2024
Comment on lines
+31
to
+41
| info_required_arguments.add_argument( | ||
| '--localqueue', | ||
| action='store_true', | ||
| help = 'Print info about localqueue', | ||
| ) | ||
|
|
||
| info_required_arguments.add_argument( | ||
| '--clusterqueue', | ||
| action='store_true', | ||
| help = 'Print info about clusterqueue', | ||
| ) |
There was a problem hiding this comment.
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Add xpk info command. There are two subcommands: xpk info localqueues, xpk info clusterqueues, for both of them there is --cluster flag supported.
Testing / Documentation
Testing details.