Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move always() to be part of the delete step #90

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Move always() to be part of the delete step #90

merged 1 commit into from
Mar 19, 2024

Conversation

Obliviour
Copy link
Collaborator

@Obliviour Obliviour commented Mar 19, 2024 •
edited
Loading

Fixes / Features

  • If the empty node pool step fails, we want to clean up the cluster. Currently if it fails, it will the TPU test.

Testing / Documentation

Testing details.

  • [ y ] Tests pass
  • [ y ] Appropriate changes to documentation are included in the PR

@Obliviour Obliviour merged commit ca9bcc4 into main Mar 19, 2024
3 of 4 checks passed
@Obliviour Obliviour deleted the nightly-test-fix branch March 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushmarchandran sushmarchandran Awaiting requested review from sushmarchandran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Obliviour