Python interface to AuditorClient #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-k
force-pushed
the
pyauditor
branch
3 times, most recently
from
d39fc50
to
d46c887
Compare
stefan-k
force-pushed
the
pyauditor
branch
5 times, most recently
from
53efb63
to
4e61548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually replace the current python client. Reduces code duplication and we can leverage all the functionality already implemented in Auditor, for instance input validation when constructing
Records. This avoids being able to constructRecords which will be rejected by the server.Comes with a bit of boilerplate and maintenance burden, but much less than keeping the Rust client and a dedicated Python client (in Python) in sync.