Initial patch for RAS configuration settings #99

abinayaddhandapani · 2024-11-29T04:36:49Z

- Added README.md with project overview.
- Added OWNERS file to define project ownership and contributors.
- Added LICENSE file to specify project licensing terms.
- Added clang-18 formatter and prettier

Interface:
com.amd.RAS.Configuration interface - - -
.GetAttribute method s v -
.SetAttribute method sv - -
.RasConfigTable property a{s(ssvx)} 9 "AifsArmed" "com.amd.RAS.Configurat... emits-change writable
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -

Tested:

Service is working well.
All the dbus methods and properties are shown correctly.
Unit test done.

root@congo-d7a4:~# systemctl status com.amd.RAS

com.amd.RAS.service - Crash dump manager
Loaded: loaded (/usr/lib/systemd/system/com.amd.RAS.service; enabled; preset: enabled)
Active: active (running) since Fri 2024-11-29 08:41:10 UTC; 14min ago
Main PID: 1993 (amd-bmc-ras)
CPU: 29ms
CGroup: /system.slice/com.amd.RAS.service
`-1993 /usr/bin/amd-bmc-ras

Nov 29 08:41:10 congo-d7a4 systemd[1]: Started Crash dump manager.
Nov 29 08:41:45 congo-d7a4 amd-bmc-ras[1993]: Attribute updated successfully

root@congo-d7a4:# busctl call com.amd.RAS /com/amd/RAS com.amd.RAS.Configuration SetAttribute sv AifsArmed b true
root@congo-d7a4:# busctl get-property com.amd.RAS /com/amd/RAS com.amd.RAS.Configuration RasConfigTable
a{s(ssvx)} 9 "AifsArmed" "com.amd.RAS.Configuration.AttributeType.Boolean" "If this field is true, AIFS flow is triggered" b true 0 "AifsSignatureId" "com.amd.RAS.Configuration.AttributeType.Boolean" "List of signature Id to check if Aifs is triggered" a{ss} 1 "EX-WDT" "0xaea0000000000108000500b020009a00000000004d000000" 0 "ApmlRetries" "com.amd.RAS.Configuration.AttributeType.Boolean" "Number of APML retry count" x 10 0 "DisableAifsResetOnSyncfloodCounter" "com.amd.RAS.Configuration.AttributeType.Boolean" "Disable AIFS Reset on syncfloow counter " b true 0 "HarvestMicrocode" "com.amd.RAS.Configuration.AttributeType.Boolean" "Harvest microcode version" b true 0 "HarvestPPIN" "com.amd.RAS.Configuration.AttributeType.Boolean" "Harvest PPIN" b true 0 "ResetSignal" "com.amd.RAS.Configuration.AttributeType.Boolean" "Reset Signal Type" s "SYS_RST" 0 "SigIdOffset" "com.amd.RAS.Configuration.AttributeType.Boolean" "List of Signature ID offsets" as 8 "0x30" "0x34" "0x28" "0x2c" "0x08" "0x0c" "null" "null" 0 "SystemRecovery" "com.amd.RAS.Configuration.AttributeType.Boolean" "System recovery mode" s "WARM_RESET" 0

ojayanth · 2024-12-01T11:36:16Z

@abinayaddhandapani Can you please add your response PR #98 that will help to avoid duplicate comments here.

ojayanth · 2024-12-01T11:40:13Z

include/config_manager.hpp

+
+#include <fstream>
+
+namespace ras_config


Guidlines:
https://github.com/CodeConstruct/openbmc-docs/blob/master/cpp-style-and-conventions.md#namespaces

Using these conventions helps maintain a clear and organized codebase, making it easier for developers to navigate and understand the structure. some thing like

Example:

namespace amd
{
namespace ras
{
configuration
{
class manager : public Base
}}}

amd::ras::configuration:;manager
amd::ras::interface::manager etc.

ojayanth · 2024-12-01T12:02:41Z

include/config_manager.hpp

+ * parameters in the D-Bus interface.
+ *
+ */
+class RasConfigManager : public Base


Should be just Manager , namespace will guide the role of this manager.

ojayanth · 2024-12-01T12:10:22Z

meson.build

+]
+
+executable(
+  'amd-bmc-ras',


amd-ras-manager ?
Service description says crash-dump-manager.
Be consistent of naming definitions.

Agreed. Will rename to amd-ras-manager everywhere.
Updated in service file as well.

ojayanth · 2024-12-01T12:18:59Z

config/ras_config.json

+            }
+        },
+        {
+            "SystemRecovery": {


I think better to include valid mode's here
"SystemRecovery": {
"Description": "System recovery mode",
"Value": "NO_RESET"
},
"ValidModes": [
{
"Mode": "Mode 1",
"Description": "xx"
},
{
"Mode": "mode 2",
"Description": "xxxx"
},

]

Will add "ValidOptions" field to verify if the given value is correct.
{
"SystemRecovery": {
"Description": "System recovery mode",
"Value": "NO_RESET",
"ValidOptions": ["COLD_RESET","WARM_RESET"]
}
},

Cahnge name to meaningful like SysRecoveryMode ?

ojayanth · 2024-12-01T12:23:31Z

config/ras_config.json

+                "Value": "NO_RESET"
+            }
+        },
+        {


It is better to group Harvesting tasks ? osme thing like
{
"HarvestingTasks": {
"HarvestMicrocode": {
"Description": "Harvest microcode version",
"Value": true
},
"HarvestPPIN": {
"Description": "Harvest PPIN",
"Value": true
}
}
}

Not combining the options so the code will be generic for all the attributes requested.

ojayanth · 2024-12-02T07:41:35Z

src/config_manager.cpp

+    }
+    catch (const std::exception& e)
+    {
+        lg2::error("Error : {ERROR}", "ERROR", e.what());


dbus error ?

I have already added dbus errors for all the errrors in the try block. Throwing exception from the catch blocks will crash the service. So adding dbus error is not needed here.

ojayanth · 2024-12-02T07:45:10Z

src/config_manager.cpp

+    if (!fs::exists(configFile)) // Check if the config file exists
+    {
+        std::string copyCommand =
+            std::string("cp ") + "/usr/share/ras-config/ras_config.json" + " " +


Can you keep json file defition at Name space scope or Meson? that wilkl help users to modify path if required.

ojayanth · 2024-12-02T07:47:43Z

src/config_manager.cpp

+            std::string("cp ") + "/usr/share/ras-config/ras_config.json" + " " +
+            configFile;
+
+        int result = system(copyCommand.c_str());


Not advised in modern c++,

if (!fs::exists(configFile)) {
try {
fs::copy(defaultConfigPath, configFile);
} catch (const fs::filesystem_error& e) {
<
return;
}
}

ojayanth · 2024-12-02T07:48:50Z

src/config_manager.cpp

+    }
+
+    std::ifstream jsonRead(configFile);
+    nlohmann::json data = nlohmann::json::parse(jsonRead);


should add error check if (!jsonRead.is_open()) {

ojayanth · 2024-12-02T07:50:48Z

src/config_manager.cpp

+
+    ConfigTable configMap;
+
+    for (const auto& item : data["Configuration"])


How about using this algorithm( not tested) , which simplify

for (const auto& item : data["Configuration"]) {
if (item.is_object() && item.size() == 1) {
const auto& key = item.begin().key();
const auto& obj = item[key];

std::string description = obj["Description"]; AttributeValue value; int64_t maxBoundValue = 0; if (obj["Value"].is_boolean()) { value = obj["Value"].get<bool>(); } else if (obj["Value"].is_string()) { value = obj["Value"].get<std::string>(); } else if (obj["Value"].is_number_integer()) { value = obj["Value"].get<int64_t>(); } else if (obj["Value"].is_array()) { value = obj["Value"].get<std::vector<std::string>>(); } else if (obj["Value"].is_object()) { value = obj["Value"].get<std::map<std::string, std::string>>(); } int attributeType = value.index(); configMap[key] = std::make_tuple(attributeType, description, value, maxBoundValue); } }

I am trying to construct rasConfigTable which contains all the datas of the json file.
Since name , description , value all are different types we need to parse it individually and create the tuple.
Else the table is not getting generated as expected

Can you share the sdbusplus::common::com::amd::ras::
Configuration::AttributeType::xx defeitions?

enumerations:
- name: AttributeType
description: >
Attribute Type.
values:
- name: Boolean
description: >
Boolean value Type
- name: String
description: >
string value Type.
- name: Integer
description: >
unsigned integer value Type.
- name: ArrayOfStrings
description: >
Array of strings value Type.
- name: KeyValueMap
description: >
key-value pairs value Type.

mahkurap · 2024-12-03T03:51:29Z

README.md

-# AMD BMC RAS 
+# AMD BMC RAS
+
+The amd - bmc - ras service is intended to discover, configure and exercise OOB


the Out Of Band (OOB)
Reliability Availability and Serviceability (RAS)

Add apml documentation public link)

I have already added the comments for this review to the chat
#99 (comment)

mahkurap · 2024-12-03T03:53:33Z

README.md

+# AMD BMC RAS
+
+The amd - bmc - ras service is intended to discover, configure and exercise OOB
+RAS capabilities supported by the processors .The application creates error


AMD processors. (no blank between the last word and the full stop). The amd-bmc-ras service (instead of the word application)

mahkurap · 2024-12-03T03:55:35Z

README.md

+
+The amd - bmc - ras service is intended to discover, configure and exercise OOB
+RAS capabilities supported by the processors .The application creates error
+records from RAS telemetry extracted from the processor over APML.


APML - first time usage, please elaborate.

mahkurap · 2024-12-03T04:00:00Z

README.md

+## Features
+
+The application waits on the APML_L gpio pin to check if any events are
+detected. When a fatal error is detected in the system , SMU responds to


no space between the word and comma.
SMU first time use

Missing

Ack

mahkurap · 2024-12-03T04:10:30Z

README.md

+register via APML to confirm an MCA error has caused the ALERT_L assertion. The
+application collects the MCA / MSR dump via APML and creates CPER record. System
+recovery is handled as per the user's preference from the config file.
+


See if the following paragraph explains the flow:
The amd-bmc-ras service reads the SBRMI registers over the APML upon the ALERT_L assertion by the SMU. It creates CPER records based on the the MCA/MSR dump. <what happens to the just created CPER record? who are the end users of it?>

Explain the System recovery feature in the next paragraph and how it is related to the just created CPER record? Then describe how the user can configure the recovery action, give a pointer where is is explained. for e.g., configuration section.

mahkurap · 2024-12-03T04:10:57Z

README.md

+
+## Configuration
+
+amd-ras is configured per the


do you mean amd-bmc-ras service?

how configuration of the service is linked with meson_options.txt? May be you want to mention what all can be configured briefly.

The meson_options.txt is not added for the initial commit. But the options.txt file will be used to get the compiler flag is the underlying protocol is APML or PLDM to harvest the errors

mahkurap · 2024-12-03T04:12:27Z

README.md

+## Configuration
+
+amd-ras is configured per the
+[meson build files](https://mesonbuild.com/Build-options.html). Available


link is inactive

The link will be active when it is clicked from the repo https://github.com/AMDESE/amd-bmc-ras/blob/review/README.md and not from the PR link

Looks like name an d link is not matching , please look.

Reply : The upstream uses the same name and the link to point out the build-options file.
Attaching link for reference:
https://github.com/openbmc/bmcweb/blob/deae6a789444debc4724fb6902fc5def299afbee/README.md?plain=1#L52

Some of the upstream repo such as bmcweb uses the same naming convention.

Please find the link for reference.

https://github.com/openbmc/bmcweb/blob/deae6a789444debc4724fb6902fc5def299afbee/README.md?plain=1#L52

ojayanth · 2024-12-04T14:08:45Z

include/config_manager.hpp

+{
+namespace ras
+{
+namespace configuration


configuration-> config

ojayanth · 2024-12-04T14:16:46Z

include/config_manager.hpp

+static constexpr auto service = "com.amd.RAS";
+static constexpr auto objectPath = "/com/amd/RAS";
+
+using Base = sdbusplus::com::amd::RAS::server::Configuration;


General: Use Meningfull names , instead of Random
"Base" -- Not able to connect namespace definition , ConfigType?

ojayanth · 2024-12-05T09:49:48Z

README.md

@@ -1,20 +1,25 @@
-# AMD BMC RAS


Commit message rule 50/72.

Commit3 - Commit message more details based on the covergae added , some thing like ( elaborate this with details)

Enable RAS Configuration Manager with D-Bus Interface

Implemented RAS Configuration Manager based on a configuration JSON file.

Added functionality to override configuration parameters via D-Bus interface.

Established D-Bus infrastructure to support RAS configuration management.

Tested:

Verified service functionality.

Confirmed all D-Bus methods and properties are displayed correctly.

Conducted unit tests to ensure reliability.

ojayanth · 2024-12-05T09:50:40Z

config/ras_config.json

+            "SystemRecovery": {
+                "Description": "System recovery mode",
+                "Value": "NO_RESET",
+                "ValidOptions": ["COLD_RESET", "WARM_RESET"]


NO_RESET is also valid option right?

yes. I will add NO_RESET to the validoptions.

ojayanth · 2024-12-05T09:54:15Z

config/ras_config.json

+        },
+        {
+            "HarvestPPIN": {
+                "Description": "Harvest PPIN",


Harvest Protected Processor Identification Number (PPIN)

ojayanth · 2024-12-05T11:56:45Z

src/config_manager.cpp

+    jsonFileOut.close();
+}
+
+/**


remove this header .

ojayanth · 2024-12-05T11:57:03Z

src/config_manager.cpp

+    jsonRead.close();
+}
+
+/**


remove header.

ojayanth · 2024-12-05T12:01:31Z

src/config_manager.cpp

+        fs::path destDir = fs::path(CONFIG_FILE).parent_path();
+        if (!fs::exists(destDir))
+        {
+            fs::create_directories(destDir);


Need to handle exceptions throw here.

ojayanth · 2024-12-05T12:08:46Z

src/config_manager.cpp

+
+    if (!jsonRead.is_open())
+    {
+        lg2::error("Error: Could not read config file");


should inform user. to act on usecase based error.

Throw exception if the config file is inaccessible

ojayanth · 2024-12-05T12:23:40Z

src/config_manager.cpp

+
+    ConfigTable configMap;
+
+    for (const auto& item : data["Configuration"])


Can you share the sdbusplus::common::com::amd::ras::
Configuration::AttributeType::xx defeitions?

ojayanth · 2024-12-08T06:22:50Z

OWNERS

+# It is expected that these 4 sections will be listed in the order above and
+# data within them will be kept sorted.
+
+owners:


Match with all required details , incase you want to fill it now . Otherwise leave you can update details one we started upstreaming activity.

ojayanth · 2024-12-08T06:28:41Z

README.md

-# AMD BMC RAS 
+# AMD BMC RAS
+
+The amd - bmc - ras service is intended to discover, configure and exercise OOB


Add apml documentation public link)

ojayanth · 2024-12-08T06:30:55Z

README.md

+
+amd-ras is configured per the
+[meson build files](https://mesonbuild.com/Build-options.html). Available
+options are documented in `meson_options.txt`


Add : Building section.
Eg:
This project uses Meson (>=1.1.1). To build for native architecture, simply run:

meson setup build
ninja -C build

ojayanth · 2024-12-08T06:47:53Z

README.md

@@ -1,20 +1,25 @@
-# AMD BMC RAS


Commit3 - Commit message more details based on the covergae added , some thing like ( elaborate this with details)

Enable RAS Configuration Manager with D-Bus Interface

Implemented RAS Configuration Manager based on a configuration JSON file.

Added functionality to override configuration parameters via D-Bus interface.

Established D-Bus infrastructure to support RAS configuration management.

Tested:

Verified service functionality.

Confirmed all D-Bus methods and properties are displayed correctly.

Conducted unit tests to ensure reliability.

ojayanth · 2024-12-08T06:53:35Z

include/config_manager.hpp

+ * @brief Manager class which adds the RAS configuration
+ * parameter values to the D-Bus interface.
+ *
+ * The class pulls the default values of ras_config.json file


add @details tag , before detiled description.

ojayanth · 2024-12-08T07:10:08Z

meson.build

+]
+
+deps = [
+	dependency('boost'),


Missing from previous reveiw

ojayanth · 2024-12-08T07:14:21Z

meson.build

+  '-DSRC_CONFIG_FILE="' + src_config_file + '"'
+]
+
+deps = [


Usually boost get unnecessary overheads on binary size and other issues . please look bios-settings-mg or other repos, to set required boost build flags setting , and add relevant here , based on your use cases.

ojayanth · 2024-12-08T07:17:26Z

meson.build

+
+executable(
+  'amd-ras-manager',
+  'src/config_manager.cpp',


This list will grow . please start grouping src files , refer any of the upstream meson file.

ojayanth · 2024-12-08T07:21:22Z

src/config_manager.cpp

+ */
+void Manager::setAttribute(AttributeName attribute, AttributeValue value)
+{
+    nlohmann::json j;


Missing comments from previous review.

ojayanth · 2024-12-08T07:25:11Z

src/config_manager.cpp

+    auto configMap = rasConfigTable();
+
+    std::ifstream jsonFile(CONFIG_FILE);
+    if (!jsonFile.is_open())


two exceptions consecutively, which is not valid. You should throw only one exception.
Looks like you are missing to address error handling , as we diecussed.
I will stoip reveiw here , will continue reveiw after you revisted error strategy in better way , as diecusssed.

throwing D-bus error should be fine. I will remove the runtime_error() exception

Looks like d-bus errors are Not documented in dbus review. Please update.

Reply : I have sent for the internal gerrit review https://gerrit-git.amd.com/c/ESE/ec/BMC/openbmc/+/1170402.
once it is approved , I will send for the upstreamreview

abinayaddhandapani · 2024-12-09T04:47:07Z

@ojayanth There is no public APML documentation link. APML is defined as part of AMD processor programming reference (PPR)

ojayanth · 2024-12-17T17:05:10Z

OWNERS

+  email: abinaya.dhandapani@amd.com
+  discord: abinayadhandapani
+- name: Jayanth Othayoth
+  email: jayanth.othayoth@amd.com


ojayanth@gmail.com

ojayanth · 2024-12-17T17:06:55Z

README.md

-# AMD BMC RAS 
+# AMD BMC RAS
+
+The amd - bmc - ras service is intended to discover, configure and exercise OOB


ojayanth · 2024-12-17T17:07:38Z

README.md

+## Features
+
+The application waits on the APML_L gpio pin to check if any events are
+detected. When a fatal error is detected in the system , SMU responds to


Missing

Ack

ojayanth · 2024-12-17T17:08:52Z

README.md

+
+amd-ras is configured per the
+[meson build files](https://mesonbuild.com/Build-options.html). Available
+options are documented in `meson_options.txt`


ojayanth · 2024-12-17T17:09:51Z

README.md

+## Configuration
+
+amd-ras is configured per the
+[meson build files](https://mesonbuild.com/Build-options.html). Available


Looks like name an d link is not matching , please look.

Reply : The upstream uses the same name and the link to point out the build-options file.
Attaching link for reference:
https://github.com/openbmc/bmcweb/blob/deae6a789444debc4724fb6902fc5def299afbee/README.md?plain=1#L52

ojayanth · 2024-12-18T03:36:10Z

src/config_manager.cpp

+    auto configMap = rasConfigTable();
+
+    std::ifstream jsonFile(CONFIG_FILE);
+    if (!jsonFile.is_open())


Looks like d-bus errors are Not documented in dbus review. Please update.

Reply : I have sent for the internal gerrit review https://gerrit-git.amd.com/c/ESE/ec/BMC/openbmc/+/1170402.
once it is approved , I will send for the upstreamreview

src/config_manager.cpp

ojayanth · 2024-12-18T04:08:04Z

src/config_manager.cpp

+{
+    if (!fs::exists(CONFIG_FILE))
+    { // Check if the config file exists
+        fs::path destDir = fs::path(CONFIG_FILE).parent_path();


Move this also in try catch box .

We have already discussed that we are not going to continue the application if the config_file is not found.

Hence I am not adding catch block here which doesnt seem to be of much use.

if I catch the exception, again I need to re-throw to terminate the application

ojayanth · 2024-12-18T07:13:02Z

src/config_manager.cpp

+        std::variant<bool, std::string, int64_t, std::vector<std::string>,
+                     std::map<std::string, std::string>>
+            value;
+        int64_t maxBoundValue = 0;


maxBoundValue should get from json , not seeing any code related to this.

- Added README.md with project overview. - Added OWNERS file to define project ownership and contributors. - Added LICENSE file to specify project licensing terms. Signed-off-by: Abinaya Dhandapani <abinaya.dhandapani@amd.com>

Added clang-18 formatter. Signed-off-by: Abinaya Dhandapani <abinaya.dhandapani@amd.com>

ojayanth · 2024-12-20T06:34:57Z

src/config_manager.cpp

+        AttributeType attributeType;
+        std::string key;
+        std::string description;
+        std::variant<bool, std::string, int64_t, std::vector<std::string>,


The value variable is declared but not initialized before checking its index.

ojayanth · 2024-12-20T06:53:13Z

src/config_manager.cpp

+            key = item.begin().key();
+
+            const auto& obj = item[key];
+            description = obj["Description"];


Error handling fro description missing need to handle.

ojayanth · 2024-12-20T06:53:48Z

src/config_manager.cpp

+            {
+                attributeType = sdbusplus::common::com::amd::ras::
+                    Configuration::AttributeType::KeyValueMap;
+            }


un suported value case need to handle.

src/config_manager.cpp

ojayanth · 2024-12-20T07:02:12Z

src/config_manager.cpp

+
+Manager::AttributeValue Manager::getAttribute(AttributeName attribute)
+{
+    auto configMap = rasConfigTable();


const type.

ojayanth · 2024-12-20T07:02:24Z

src/config_manager.cpp

+    AttributeValue value;
+    bool found = false;
+
+    for (auto& [key, tuple] : configMap)


ojayanth · 2024-12-20T07:06:28Z

src/config_manager.cpp

+
+                if (isValidValue)
+                {
+                    lg2::error(


add attribute name and value - usefull for debug

ojayanth · 2024-12-20T07:07:19Z

src/config_manager.cpp

+            }
+            else
+            {
+                lg2::error("Valid option not provided");


add attribute name /value.

ojayanth · 2024-12-20T07:07:59Z

src/config_manager.cpp

+    }
+    else
+    {
+        lg2::error("Attribute not found");


add attribute name .

1. Added RAS configuration class which creates the RAS configuration interface to set and get the config values. 2. The setAttribute and getAttribute methods are overridden in the class to update the ras_config.json with the latest values. Tested: 1. Service is working well. 2. All the dbus methods and properties are shown correctly. Able to get and update the ras_config.json file using D-Bus methods. 3. Unit test done. root@xxxx:~# busctl tree com.amd.RAS `- /com `- /com/amd `- /com/amd/RAS Signed-off-by: Abinaya Dhandapani <abinaya.dhandapani@amd.com>

abinayaddhandapani requested review from supven01 and ojayanth November 29, 2024 04:37

abinayaddhandapani changed the title ~~Add README, OWNERS, LICENSE , clang-format , prettier files~~ Initial patch for RAS configuration settings Nov 29, 2024

abinayaddhandapani force-pushed the review branch 3 times, most recently from b48f6a2 to 980f9a6 Compare November 29, 2024 10:28

ojayanth suggested changes Dec 2, 2024

View reviewed changes

abinayaddhandapani requested review from rajaganeshr, srgovard, modolaty, ashok2ku and mahkurap December 2, 2024 08:00

mahkurap suggested changes Dec 3, 2024

View reviewed changes

mahkurap approved these changes Dec 3, 2024

View reviewed changes

abinayaddhandapani force-pushed the review branch 2 times, most recently from 8b07659 to d46cde6 Compare December 5, 2024 05:35

ojayanth suggested changes Dec 5, 2024

View reviewed changes

abinayaddhandapani force-pushed the review branch from d46cde6 to 59c7df1 Compare December 6, 2024 14:59

ojayanth suggested changes Dec 8, 2024

View reviewed changes

abinayaddhandapani force-pushed the review branch from 59c7df1 to d55d52e Compare December 16, 2024 12:28

ojayanth suggested changes Dec 18, 2024

View reviewed changes

Abinaya Dhandapani added 2 commits December 19, 2024 10:51

Add README, OWNERS, and LICENSE files

6d50683

- Added README.md with project overview. - Added OWNERS file to define project ownership and contributors. - Added LICENSE file to specify project licensing terms. Signed-off-by: Abinaya Dhandapani <abinaya.dhandapani@amd.com>

Add clang-format and prettier

fb5477f

Added clang-18 formatter. Signed-off-by: Abinaya Dhandapani <abinaya.dhandapani@amd.com>

abinayaddhandapani force-pushed the review branch from d55d52e to 78a1c09 Compare December 19, 2024 16:54

ojayanth suggested changes Dec 20, 2024

View reviewed changes

abinayaddhandapani force-pushed the review branch from 78a1c09 to c07119b Compare December 20, 2024 19:04


		ConfigTable configMap;

		for (const auto& item : data["Configuration"])

Initial patch for RAS configuration settings #99

Are you sure you want to change the base?

Initial patch for RAS configuration settings #99

Conversation

abinayaddhandapani commented Nov 29, 2024 • edited Loading

ojayanth commented Dec 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ojayanth Dec 17, 2024 • edited by abinayaddhandapani Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ojayanth Dec 17, 2024 • edited by abinayaddhandapani Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abinayaddhandapani commented Nov 29, 2024 •

edited

Loading

ojayanth commented Dec 1, 2024 •

edited

Loading

ojayanth Dec 17, 2024 •

edited by abinayaddhandapani

Loading

ojayanth Dec 17, 2024 •

edited by abinayaddhandapani

Loading