Update versions to v3.1.2 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrc-benmorrow
pushed a commit
that referenced
this pull request
Jul 25, 2024
amrc-benmorrow
pushed a commit
that referenced
this pull request
Jul 25, 2024
amrc-benmorrow
added a commit
that referenced
this pull request
Jul 25, 2024
Service registration over HTTP was not correctly recording the associated Sparkplug device. This was causing issues with clients that need to access the change-notify interface. More fundamentally, the service registration table was allowing a distinction between 'the principal which registered this service' and 'the Sparkplug device associated with this service'. This was because when the interface was designed I was trying to allow a Kerberos principal and its associated Sparkplug Node to use different UUIDs. Since then I have decided that this is incorrect, and the Sparkplug Node address is simply an alternative identifier for the same principal as the Kerberos UPN. Remove the separate `principal` table, and simply record service registrations as owned by their Sparkplug device.
amrc-benmorrow
added a commit
that referenced
this pull request
Jul 25, 2024
Associate a Sparkplug Group with each cluster. Create a Sparkplug Address entry giving just the `group_id`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.