Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement exact Riemann solver as hydro option #2285

Open
maxpkatz opened this issue Oct 28, 2022 · 2 comments
Open

Implement exact Riemann solver as hydro option #2285

maxpkatz opened this issue Oct 28, 2022 · 2 comments
Assignees
@zingale
Labels
hydro

Comments

@maxpkatz
Copy link
Member

It would be interesting to have an option to run the exact Riemann solver in the main Castro code, so we could more easily compare both accuracy and performance for any particular problem setup between the approximate/HLL solvers and the exact solver.
@maxpkatz maxpkatz added the hydro label Oct 28, 2022
@zingale
Copy link
Member

zingale commented Jun 8, 2024

this will be straightforward once #2869 is merged. Then there is just a bit more cleaning.

@zingale
Copy link
Member

zingale commented Jul 9, 2024

once #2897 is merged, I can move the relevent headers into Castro/Source/hydro and then hook this in as an option.

@zingale zingale mentioned this issue Jul 10, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zingale zingale

Labels
hydro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zingale @maxpkatz