Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish riemann cleaning #2897

Merged
merged 41 commits into from
Jul 10, 2024
Merged

Finish riemann cleaning #2897

merged 41 commits into from
Jul 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 1, 2024 •
edited
Loading

PR summary

we now rely on Source/hydro/riemann_constants.H for all of the necessary
tolerances.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
fix some namespace issues + add missing headers to runtime_parameters.H
fe81e5d 
this will make it easier to use this for non-castro things (like
exact_riemann)
@zingale
more work on getting castro params into exact Riemann
000768f
@zingale
this seems to work
d01fa53
@zingale
Merge branch 'development' into exact_riemann_castro_params
94d35b2
@zingale
this works now
a4a16d3
@zingale
add missing file
b0b48bb
@zingale
Merge branch 'development' into exact_riemann_castro_params
c08294d
@zingale
Merge branch 'development' into exact_riemann_castro_params
afcb2dc
@zingale
unused header
8b81044
@zingale
Merge branch 'exact_riemann_castro_params' of github.com:zingale/Cast…
a3c59f6 
…ro into exact_riemann_castro_params
@zingale
rename some Riemann runtime parameters
372229c 
now they have "riemann" in their name, and also some
drop "cg" so that it is clear that they can apply to other
solvers
@zingale
fix runtime params
1f3a733
@zingale
Merge branch 'rename_riemann_runtime' into next_exact_riemann
07307ec
@zingale
work on using Source/hydro riemann parameters
f6363f2
@zingale
move some Riemann history constexpr to riemann_constants namespace
03b9653
@zingale
Merge branch 'move_history_params_to_riemann' into next_exact_riemann
ad30404
@zingale
split constants into riemann_constants.H
9e7e820 
allow the exact Riemann solver to use the new constants
@zingale
Merge branch 'development' into exact_riemann_castro_params
0d51f94
@zingale
Merge branch 'exact_riemann_castro_params' into move_history_params_t…
a3f5802 
…o_riemann
@zingale
Merge branch 'move_history_params_to_riemann' into next_exact_riemann
a932e27
@zingale
remove unneeded header
9b1cf4d
@zingale
more work on getting the Riemann solver to fully use Castro stuff
0a6ce88
@zingale
for pstar convergence in exact_riemann use std::abs()
17431ba
@zingale
remove the ustar test
65a818c
@zingale
Merge branch 'development' into move_history_params_to_riemann
d3f70a6
@zingale
Merge branch 'development' into next_exact_riemann
4a134a9
@zingale
Merge branch 'development' into finish_riemann_cleaning
6aa51c3
@zingale
Merge branch 'development' into fix_exact_riemann_pstar_test
bbcd4d8
@zingale
fix header guard
22a9572
@zingale
Merge branch 'next_exact_riemann' into finish_riemann_cleaning
a204219
@zingale zingale added the hydro label Jul 9, 2024
@zingale zingale changed the title [WIP] Finish riemann cleaning Finish riemann cleaning Jul 9, 2024
@zingale zingale mentioned this pull request Jul 9, 2024
Open
@zingale zingale merged commit 5590794 into AMReX-Astro:development Jul 10, 2024
26 checks passed
@zingale zingale deleted the finish_riemann_cleaning branch July 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
hydro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3