Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std::clamp to make some code clearer #2905

Merged
merged 5 commits into from
Jul 10, 2024
Merged

use std::clamp to make some code clearer #2905

merged 5 commits into from
Jul 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 9, 2024

also swtich to std::min/max where appropriate (instead of amrex::)

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit 8b289c1 into AMReX-Astro:development Jul 10, 2024
25 checks passed
@zingale zingale deleted the clamp branch July 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3