Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch the MHD / MOL hydro to use the flatten header #2906

Merged
merged 2 commits into from
Jul 10, 2024
Merged

switch the MHD / MOL hydro to use the flatten header #2906

merged 2 commits into from
Jul 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 9, 2024

this eliminates the duplicate flatten.cpp version

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
switch the true-SDC / MOL hydro to use the flatten header
e8332d5 
this eliminates the duplicate flatten.cpp version
@zingale zingale changed the title switch the true-SDC / MOL hydro to use the flatten header switch the MHD / MOL hydro to use the flatten header Jul 9, 2024
@zingale
Copy link
Member Author

zingale commented Jul 9, 2024

quick tests pass:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-07-09-001/index.html

@zingale zingale merged commit dd89b8e into AMReX-Astro:development Jul 10, 2024
25 checks passed
@zingale zingale deleted the mol_flatten branch July 10, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz