-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minerbo initial conditions #59
Conversation
Cool! Do you have a reference for these closure parameters? |
Minerbo 1978 |
5356e0b
to
87c00ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is this setup acting like another test problem, or is it something that could also be used for "fiducial" runs? Is it sort of an improvement on simulation_type=4, or do they do different things?
The Fiducial runs set up the initial distribution as linear in costheta (where theta is the angle between the neutrino direction and the flux direction). But most moment-based radiation transport simulations assume the distribution is exponential with costheta. So this sets up a new type of problem that follows the same assumptions as those used in the transport calculations. This will allow us to, say, grab a position in a 3D simulation of a neutron star merger and simulate those parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the comment clarifications this looks good to me!
…ctation value of 1. Was getting results too small by a factor of 4pi before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* Added descriptive amrex::Error messages in generate_code.py (#53) * Added descriptive amrex::Error messages in generate_code.py Swtiched amrex::Abort to amrex::Error with descriptive error message * added more to amrex::Error messages * added grid variable to use in timestep calculation * add ability to do scalar math with HermitianMatrix-es * added 3 flavor functionality to sample_inputs test simulations. Note: mass3_eV = 0 for these to run. (#56) * update readme for code generation and fix commutator language (#55) * rewrite how the magnitude of a complex number is written so sympy simplifies the result without extraneous Is in real numbers * use amrex reduction functions to evaluate and reduce Hamiltonian flavor vector length in place * reduce the flavor cfl factor in the input files to account for the fact that the timestep is more liberal now * separate the SU vector magnitude function into one that returns the magnitude and one that returns the magnitude squared. This will allow us to add the flux components without repeatedly square rooting and squaring. * added flux term to max hamiltonian for timestep calculation * make the timestep account for the vacuum potential as well. Compute the minimum particle energy in initializing step to avoid doing a reduction over particles at every timestep under the assumption that particle energies do not change * fixed unit issue with max vacuum potential * override copyParticles function to also copy the new Vvac_max member variable * fixed broken implementation of conjugate * fixed error in generate code - the length of the Hamiltonian vector needs antineutrinos to be conjugated * pushed flavor cfl factors back up as high as they can go without runing into the maxError limit * set the reduction operator to return a second quantity. Will be used to limit timestep based on total lepton density * account for vacuum potential. Also cover case where total potential is 0 because of equal numbers of neutrinos and antineutrinos by introducing a parameter (max_adaptive_speedup). When set to 0 it behaves exactly as before, except for the inclusion of the vacuum potential in the timestep calculation. When set towards infinity, it always allows the "optimized" timestep, which may itself become infinite if terms happen to cancel by chance, but otherwise is a much better estimate of the required timestep * forgot to update the 1d_fiducial inputs file * addressing PR comments. Use static inline variable rather than overriding the ParticleContainer copy operator, fix mistake in conjugation of Hermitian matrices. * Minerbo initial conditions (#59) * added vscode and generated_files directories to the gitignore file * added Minerbo closure initial conditions * added references for the minerbo equations * added a tad more explanatory text * improved st5 code comments * fixed coefficient in front of minerbo closure to make it have an expectation value of 1. Was getting results too small by a factor of 4pi before. Co-authored-by: Sherwood Richers <srichers@caltech.edu> * Output build info (#63) * Copied Castro function for printing build information to screen * Copy castro function for outputting information into plotfiles, simply deleting lines that don't work in emu Co-authored-by: Sherwood Richers <srichers@caltech.edu> * im stoopid - fixing timestep logic Co-authored-by: Nicole F <73133869+nmford20@users.noreply.github.com> Co-authored-by: Sherwood Richers <srichers@caltech.edu> Co-authored-by: Don E. Willcox <dwillcox@users.noreply.github.com>
Add in initial condition method that allows us to input the density and flux vector of each species.