Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework phys_bc to use BCRec #469

Merged
merged 14 commits into from
Jul 18, 2024
Merged

Rework phys_bc to use BCRec #469

merged 14 commits into from
Jul 18, 2024

Conversation

biboyd
Copy link
Collaborator

@biboyd biboyd commented May 24, 2024

Removes the use of a ManagedVectoras well as makes the accessing of phys_bc more consistent throughout

@zingale
Copy link
Member

zingale commented May 26, 2024

tests pass: http://groot.astro.sunysb.edu/MAESTROeX/test-suite/gfortran/2024-05-24-001/index.html

@zingale
Copy link
Member

zingale commented Jul 17, 2024

now flame_3d fails:
http://groot.astro.sunysb.edu/MAESTROeX/test-suite/gfortran/2024-07-17-001/index.html

@zingale
Copy link
Member

zingale commented Jul 18, 2024

actually, that flame3d failure is unrelated. It is happening in development too

@zingale zingale merged commit 6bc2822 into AMReX-Astro:development Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biboyd @zingale