Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windows and/or includes (iso646) #1593

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 2, 2020

Summary

Add missing includes to AMReX_Extension.H, which pulls the <iso646.h> include on Windows for support for and/or.

Additional background

Seen with Clang 11.0.0 on x64 Windows with Visual Studio 2017 on conda-forge during a WarpX build.

See also #947

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@ax3l ax3l added the bug label Dec 2, 2020
@ax3l
Copy link
Member Author

ax3l commented Dec 3, 2020

Hm, patch looks needed but the original issue I saw with VS2017 and Clang11 on CF is not fixed yet.

@WeiqunZhang It looks like even other major libs gave up on and/or/not keywords: nlohmann/json#2259

Background:

Maybe VS2019 just fixed the need for this header... https://docs.microsoft.com/en-us/cpp/standard-library/ciso646?view=msvc-160&viewFallbackFrom=vs-2019

Add missing includes to `AMReX_Extension.H`, which pulls the
`<iso646.h>` include on Windows for support for `and`/`or`.

Seen with Clang 11.0.0 on x64 Windows with Visual Studio 2017 on
conda-forge during a WarpX build.
@WeiqunZhang WeiqunZhang merged commit ef665e2 into AMReX-Codes:development Dec 3, 2020
@ax3l ax3l deleted the fix-andOrWin branch December 4, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants