Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify/remove the assertions about no hidden dimension since this cas… #4180

Merged
merged 1 commit into from
Oct 3, 2024
Merged

modify/remove the assertions about no hidden dimension since this cas… #4180

merged 1 commit into from
Oct 3, 2024

Conversation

asalmgren
Copy link
Member

…e is working in ERF

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@asalmgren asalmgren merged commit f3514e4 into AMReX-Codes:development Oct 3, 2024
59 checks passed
@asalmgren asalmgren deleted the fix_for_hidden_dimension branch October 3, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asalmgren @WeiqunZhang