Skip to content

Commit

Permalink
clang-tidy fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
baperry2 committed Oct 9, 2024
1 parent 83a6f4a commit a9e4723
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 16 deletions.
4 changes: 0 additions & 4 deletions Exec/RegTests/EB-Rotor4Blade/prob.H
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ pc_initdata(
amrex::GeometryData const& geomdata,
ProbParmDevice const& prob_parm)
{
// Geometry
const amrex::Real* prob_lo = geomdata.ProbLo();
const amrex::Real* dx = geomdata.CellSize();

amrex::Real u = 0.0;
amrex::Real v = 0.0;
amrex::Real w = 0.0;
Expand Down
4 changes: 2 additions & 2 deletions Exec/RegTests/EB-Rotor4Blade/prob.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ amrex_probinit(
const int* /*init*/,
const int* /*name*/,
const int* /*namelen*/,
const amrex::Real* problo,
const amrex::Real* probhi)
const amrex::Real* /*problo*/,
const amrex::Real* /*probhi*/)
{
// Parse params
amrex::ParmParse pp("prob");
Expand Down
4 changes: 2 additions & 2 deletions Exec/RegTests/EB-Rotor4Blade/prob_parm.H
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ struct ProbParmDevice
amrex::Real mu = 0.1;
amrex::Real kappa = 1.0;
amrex::GpuArray<amrex::Real, NUM_SPECIES> massfrac = {1.0};
int do_rf = 0;
bool do_rf = 0;

Check warning on line 17 in Exec/RegTests/EB-Rotor4Blade/prob_parm.H

View workflow job for this annotation

GitHub Actions / Lint-clang-tidy

converting integer literal to bool, use bool literal instead [modernize-use-bool-literals]

Check warning on line 17 in Exec/RegTests/EB-Rotor4Blade/prob_parm.H

View workflow job for this annotation

GitHub Actions / Lint-clang-tidy

implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
amrex::Real rf_omega = 0;
amrex::Real rf_axis = 2;
int rf_axis = 2;
amrex::Real rf_axis_x = 0.0;
amrex::Real rf_axis_y = 0.0;
amrex::Real rf_axis_z = 0.0;
Expand Down
4 changes: 0 additions & 4 deletions Exec/RegTests/EB-TaylorCouette/prob.H
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ pc_initdata(
amrex::GeometryData const& geomdata,
ProbParmDevice const& prob_parm)
{
// Geometry
const amrex::Real* prob_lo = geomdata.ProbLo();
const amrex::Real* dx = geomdata.CellSize();

amrex::Real u = 0.0;
amrex::Real v = 0.0;
amrex::Real w = 0.0;
Expand Down
4 changes: 2 additions & 2 deletions Exec/RegTests/EB-TaylorCouette/prob.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ amrex_probinit(
const int* /*init*/,
const int* /*name*/,
const int* /*namelen*/,
const amrex::Real* problo,
const amrex::Real* probhi)
const amrex::Real* /*problo*/,
const amrex::Real* /*probhi*/)
{
// Parse params
amrex::ParmParse pp("prob");
Expand Down
4 changes: 2 additions & 2 deletions Exec/RegTests/EB-TaylorCouette/prob_parm.H
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ struct ProbParmDevice
amrex::Real mu = 0.1;
amrex::Real kappa = 1.0;
amrex::GpuArray<amrex::Real, NUM_SPECIES> massfrac = {1.0};
int do_rf = 0;
bool do_rf = 0;

Check warning on line 17 in Exec/RegTests/EB-TaylorCouette/prob_parm.H

View workflow job for this annotation

GitHub Actions / Lint-clang-tidy

converting integer literal to bool, use bool literal instead [modernize-use-bool-literals]

Check warning on line 17 in Exec/RegTests/EB-TaylorCouette/prob_parm.H

View workflow job for this annotation

GitHub Actions / Lint-clang-tidy

implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
amrex::Real rf_omega = 0;
amrex::Real rf_axis = 2;
int rf_axis = 2;
amrex::Real rf_axis_x = 0.0;
amrex::Real rf_axis_y = 0.0;
amrex::Real rf_axis_z = 0.0;
Expand Down

0 comments on commit a9e4723

Please sign in to comment.