Changed wording #216
Closed
Changed wording #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed wording to allow none IANA media types which are otherwise well defined
| @@ -12,7 +12,7 @@ | |||
| ], | |||
| "properties": { | |||
| "media_type": { | |||
| "description": "Subclassification of the format using IANA assigned media types", | |||
| "description": "Subclassification of the format using IANA assigned media types, if available", | |||
There was a problem hiding this comment.
Should we try to write these in such a way so it doesn't seem that the field is optional if there isn't an IANA assigned media type?
Suggested change
| "description": "Subclassification of the format using IANA assigned media types, if available", | |
| "description": "Subclassification of the format (prefer IANA assigned media types where available)", |
| @@ -25,7 +25,7 @@ | |||
| "type": "object", | |||
| "properties": { | |||
| "media_types": { | |||
| "description": "Subclassification of the formats accepted using IANA assigned media types", | |||
| "description": "Subclassification of the formats accepted using IANA assigned media types, if available", | |||
There was a problem hiding this comment.
Should we try to write these in such a way so it doesn't seem that the field is optional if there isn't an IANA assigned media type?
Suggested change
| "description": "Subclassification of the formats accepted using IANA assigned media types, if available", | |
| "description": "Subclassification of the formats (prefer IANA assigned media types where available)", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed wording to allow non-IANA media types which are otherwise well defined