Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema "default" in PATCH requests considered harmful #46

Closed
garethsb opened this issue Nov 29, 2019 · 0 comments · Fixed by #49
Closed

JSON schema "default" in PATCH requests considered harmful #46

garethsb opened this issue Nov 29, 2019 · 0 comments · Fixed by #49

Comments

@garethsb
Copy link
Contributor

garethsb commented Nov 29, 2019

https://github.com/AMWA-TV/nmos-network-control/blob/v1.0.x/APIs/schemas/network-flow-patch.json has a "default" on "forward_flow". I think this is wrong, since it's unclear, when the client request omits this property, whether the current value is replaced with the default or not. The best thing would be to remove the default in this schema. (The "dscp" property description also still says "default is CS0" even though the default has been removed from that property, so that could also be worth clearing up.)

(Similar issue has previously been dealt with in IS-05: AMWA-TV/is-05#37.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant