-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple URL parameters in auto tests endpoints. #851
Allow multiple URL parameters in auto tests endpoints. #851
Conversation
jonathan-r-thorpe
commented
Apr 23, 2024
- This removes the current limitation of a single URL parameter in an endpoint URL when running auto tests.
- This is a problem for the emerging IS-14 API as this has endpoints with two URL parameters.
- This code is generalized to allow any number of URL parameters, simplifying the existing implementation.
This is awesome, no doubt... one of those cases where it feels like test code needs tests to ensure no regression, or at least maybe a demo on all the existing parameterized APIs that the same coverage is produced by the new implementation, maybe? |
Thanks @garethsb! I'm going to modify the code so the error message format is identical to the original code: this code just reports the path with the parameters embedded, whereas the original code reports the parameter values only. (In the case of no parameters, including the path seems a bit redundant). I was then going to do an A/B comparison for each of the test suites against nmos-cpp's Node and Registry. Assuming there are no differences would that be sufficient to prove no regressions? |
…test result for paths dependent on failed parameterized endpoints.
Sounds great to me! Can check all IS-04 APIs, IS-05, IS-07, IS-08, this way. I guess you may want to do one test with non-zero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better than good to me! Thank you, @jonathan-r-thorpe