-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search experience #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMythicDev
force-pushed
the
improve-search-exp
branch
from
September 27, 2023 11:01
046136f
to
02937b1
Compare
Due to this the / would be displayed for the search mode character which are ? and / for backward and forward search respectively regardless of whatever search mode the user activated
This adds two new keybindings <c-left> and <c-rght> to jump between words inside the search prompt area. Also added support for Delete key to delete character at front.
This patch fixes the following bugs:- - Spaces and symbols not being recognised as separate word entities. - Remove column number of very next column to last column from being included in word list - Fix off-by-one error when jumping by word towards left - Funky behaviour of ctrl+left/ctrl+right keys
AMythicDev
force-pushed
the
improve-search-exp
branch
from
September 29, 2023 20:47
056ac8a
to
45b65a6
Compare
AMythicDev
added a commit
that referenced
this pull request
Oct 3, 2023
AMythicDev
added a commit
that referenced
this pull request
Oct 11, 2023
AMythicDev
added a commit
that referenced
this pull request
Oct 11, 2023
AMythicDev
added a commit
that referenced
this pull request
Oct 11, 2023
AMythicDev
added a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overall search experience inside minus which includes more keybindings, bug fixes and APi improvements. These are planned:-
Home
andEnd
keys respectively.C+left
andC+right
key combinations.