Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search experience #104

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Improve search experience #104

merged 7 commits into from
Sep 29, 2023

Conversation

AMythicDev
Copy link
Owner

@AMythicDev AMythicDev commented Sep 13, 2023

This PR improves the overall search experience inside minus which includes more keybindings, bug fixes and APi improvements. These are planned:-

  • Moving left and right with left and right arrow keys
  • Jumping to beginning and end of text using Home and End keys respectively.
  • Jumping from one word to another C+left and C+right key combinations.
  • Support for adding/deleting characters from any position.
  • Add tests related to keybindings in search mode.

@AMythicDev AMythicDev added the A-search Search system inside minus label Sep 13, 2023
@AMythicDev AMythicDev added this to the v5.5.0 milestone Sep 13, 2023
@AMythicDev AMythicDev self-assigned this Sep 13, 2023
Due to this the / would be displayed for the search mode character
which are ? and / for backward and forward search respectively
regardless of whatever search mode the user activated
This adds two new keybindings <c-left> and <c-rght> to jump between
words inside the search prompt area. Also added support for Delete key
to delete character at front.
This patch fixes the following bugs:-
- Spaces and symbols not being recognised as separate word entities.
- Remove column number of very next column to last column from being
  included in word list
- Fix off-by-one error when jumping by word towards left
- Funky behaviour of ctrl+left/ctrl+right keys
@AMythicDev AMythicDev merged commit ecd25dd into main Sep 29, 2023
6 checks passed
@AMythicDev AMythicDev deleted the improve-search-exp branch September 29, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-search Search system inside minus
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant