Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "rust-src" to devShell #125

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

TornaxO7
Copy link
Contributor

rust-analyzer doesn't work for me, because I also need rust-src but flakes override wipes the entries in the toolchain.

@AMythicDev
Copy link
Owner

I think the best option then would be to just drop the rust-toolchain.toml and configure the devShell in flake.nix only.

@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Dec 21, 2023

I think the best option then would be to just drop the rust-toolchain.toml and configure the devShell in flake.nix only.

so you would say that you don't want the rust-toolchain.toml at all? I mean, it's also helpful for non-nix-users.

@AMythicDev
Copy link
Owner

I think that's enough clear in the README about the MSRV plus there's no such problem with the nightly release (I can say that because I run the latest nightly) and all the intermediate releases. Hence I don't know how useful is that file for non-nix user. I mean I atleast have to run cargo with +nightly flag always. Rest I can only respect other people's DXs on this stuff.

@TornaxO7
Copy link
Contributor Author

Okeydokey!

@TornaxO7
Copy link
Contributor Author

done!

@AMythicDev AMythicDev merged commit 46034a5 into AMythicDev:main Dec 21, 2023
6 checks passed
@AMythicDev
Copy link
Owner

Merged.

@AMythicDev AMythicDev added the M: dev DX enhancements label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: dev DX enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants