Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using Jujutsu on Windows 10/11 in PowerShell, I discovered a bug that's very easy to fix. Whenever I enter the pager (for example with
jj log
) for the second time in a row, it fails to properly repaint. That's because the order of operations interm::cleanup
is not exactly the inverse ofterm::setup
. The problem is that theEnableMouseCapture
command in crossterm stores the current mode andDisableMouseCapture
restores it, so in effect it used to restore raw mode (which was enabled before enabling mouse capture) during cleanup after having disabled it.I only observed this behavior in PowerShell so far, not
cmd.exe
. Maybe only PowerShell respects these accidentally mixed up mode settings between invocations whilecmd.exe
restores the original mode somehow.