Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and eventually align the scaling functionality #53

Closed
3 tasks done
gcroci2 opened this issue Mar 20, 2024 · 0 comments · Fixed by #90
Closed
3 tasks done

Check and eventually align the scaling functionality #53

gcroci2 opened this issue Mar 20, 2024 · 0 comments · Fixed by #90
Assignees
@gcroci2
Labels
Task
Milestone
M1.1a

Comments

@gcroci2
Copy link
Contributor

gcroci2 commented Mar 20, 2024 •
edited
Loading

Referring to the scaling functionality encoded in the _minmaxscaler protected method in the Task class, we should:

  • Check that the scaling is done after the noise addition
  • Check how intensities are set now (does it keep 0.8?)
  • Implement a way to distinguish across signals intensities across tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcroci2 gcroci2

Labels
Task
Projects
None yet
Milestone
M1.1a
Development

Successfully merging a pull request may close this issue.

feature: make the scaling absolute across all the trials ANNUBS/annubes
1 participant
@gcroci2