Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: make the scaling absolute across all the trials #90

Merged
merged 4 commits into from
May 21, 2024

Conversation

gcroci2
Copy link
Contributor

@gcroci2 gcroci2 commented May 3, 2024

  • The scaling in the input signals is done after the noise addition - no edit here, it was already like that.
  • stim_intensities is now used as a list of possible values for the stimulus, i.e., when the stimulus is present. The absence of the stimulus is encoded with a 0 value. Then, the noise is added and eventually, the signals are scaled between 0 and 1 (if scaling is True). I clarified this in the Task's doc string.
  • Now the scaling is done after having created all input and output signals, and the absolute maximum and minimum values are used for doing it. So if fix_intensity is set to 2 and stim_intensities has lower values, and with the noise addition it becomes e.g. 2.15, the latter will be considered as the highest value in the trials and used to scale all the signals in the range 0-1. This way the relativity across signals is maintained, but everything is in the 0-1 range.

Copy link
Contributor Author

gcroci2 commented May 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gcroci2 and the rest of your teammates on Graphite Graphite

@gcroci2 gcroci2 marked this pull request as ready for review May 3, 2024 10:06
@gcroci2 gcroci2 requested a review from DaniBodor May 3, 2024 10:06
@gcroci2 gcroci2 linked an issue May 3, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to trials from different epochs during training?
From memory, I think it was also important that the degree of rescaling does not change between epochs, even if that means that the resulting scale is not exactly (0,1) in every epoch. Or am I misremembering this?

annubes/task.py Outdated Show resolved Hide resolved
Co-authored-by: Dani Bodor <d.bodor@esciencecenter.nl>
@gcroci2
Copy link
Contributor Author

gcroci2 commented May 8, 2024

How does this relate to trials from different epochs during training? From memory, I think it was also important that the degree of rescaling does not change between epochs, even if that means that the resulting scale is not exactly (0,1) in every epoch. Or am I misremembering this?

An epoch is a complete pass of the entire dataset (for us, all the generated trials, being trials our dataset), so these edits shouldn't influence that part at all.

Base automatically changed from fix_build_trials_inputs to main May 10, 2024 13:40
@gcroci2 gcroci2 changed the title clarify stim_intensities in the doc string feature: make the scaling absolute across all the trials May 14, 2024
@gcroci2 gcroci2 merged commit 9050771 into main May 21, 2024
5 of 7 checks passed
@gcroci2 gcroci2 deleted the 53_align_scaling_gcroci2 branch May 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check and eventually align the scaling functionality
2 participants