Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ament_export_targets in grid_map_costmap_2d #424

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Use ament_export_targets in grid_map_costmap_2d #424

merged 3 commits into from
Feb 20, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Feb 12, 2024

Purpose

Dependencies

@Ryanf55
Use ament_export_targets
c0c7ef1 
* Link to exported namespace targets when possible

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@Ryanf55 Ryanf55 added this to the 2.2.0 milestone Feb 12, 2024
@Ryanf55 Ryanf55 changed the title Use ament_export_targets Use ament_export_targets in grid_map_costmap_2d Feb 12, 2024
@Ryanf55 Ryanf55 marked this pull request as ready for review February 14, 2024 04:15
@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Feb 14, 2024
@Ryanf55 Ryanf55 requested a review from wep21 February 16, 2024 05:23
@Ryanf55
Fix whitespace, make INTERFACE type
fb02029 
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@Ryanf55
Remove extra whitespace
8c3abed 
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@Ryanf55 Ryanf55 requested a review from wep21 February 20, 2024 05:30
wep21
wep21 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ryanf55 Ryanf55 merged commit 99c998c into ANYbotics:rolling Feb 20, 2024
2 checks passed
@Ryanf55 Ryanf55 deleted the modern-ament-grid-map-costmap-2d branch February 20, 2024 13:03
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Feb 20, 2024

@Mergifyio backport iron

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Feb 20, 2024

@Mergifyio backport humble

@mergify Mergify
Copy link

mergify bot commented Feb 20, 2024 •
edited
Loading

backport iron

✅ Backports have been created

@mergify Mergify
Copy link

mergify bot commented Feb 20, 2024 •
edited
Loading

backport humble

✅ Backports have been created

This was referenced Feb 20, 2024
Merged
Merged
Ryanf55 added a commit that referenced this pull request Feb 20, 2024
@Ryanf55
Merge pull request #448 from ANYbotics/mergify/bp/iron/pr-424
e3fad51 
Use ament_export_targets in grid_map_costmap_2d (backport #424)
Ryanf55 added a commit that referenced this pull request Jul 28, 2024
@Ryanf55
Merge pull request #449 from ANYbotics/mergify/bp/humble/pr-424
69c100f 
Use ament_export_targets in grid_map_costmap_2d (backport #424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 approved these changes

Assignees
No one assigned
Labels
ros2 Affects ROS 2
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryanf55 @wep21