You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like an oversight that we are missing a limit on the amount of zero-padded bytes.
It is a requirement of bitstream conformance that the most significant bit of leb128_byte is equal to 0 if i is equal to 7. (This ensures that this syntax descriptor never uses more than 8 bytes.)
The benefit of allowing zero-padded bytes is to allow certain use-cases to leave leb128s blank, but fill them in arbitrarily later. But it seems prudent to limit the amount of zero-padded bytes. I think we intended this, but it was just missed in review.
I suggest adding language similar to the AV1 quote above to the IAMF definition of leb128().
The text was updated successfully, but these errors were encountered:
In a draft version of the spec we used normatively reference AV1 to define
leb128
.This was changed in https://github.com/AOMediaCodec/iamf/pull/558/files to bring in an explicit definition. Later a NOTE was added to clarify that "leading zero bytes" are allowed.
It seems like an oversight that we are missing a limit on the amount of zero-padded bytes.
The benefit of allowing zero-padded bytes is to allow certain use-cases to leave
leb128
s blank, but fill them in arbitrarily later. But it seems prudent to limit the amount of zero-padded bytes. I think we intended this, but it was just missed in review.I suggest adding language similar to the AV1 quote above to the IAMF definition of
leb128()
.The text was updated successfully, but these errors were encountered: