Fix #792: Define a box for configOBUs.
#794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Future backwards compatible extensions can be put at the end of `IAConfigurationRecord`.
- Future non-backwards compatible extensions will require `configurationVersion` to be bumped.
|
We probably want to allow some time to update the reference software and reference bitstream based on this change before we merge it in. But we can at least begin the initial review and work on any editorial fixes to the change in the meantime. |
…ationBox`. Add some editorial updates and additional information to clarify expected behavior for backwards compatibility. Co-authored-by: sunghee-hwang <97494915+sunghee-hwang@users.noreply.github.com>
jwcullen
commented
Dec 22, 2023
sunghee-hwang
approved these changes
Dec 22, 2023
jamrial
reviewed
Dec 23, 2023
jamrial
reviewed
Dec 23, 2023
…ion of the spec. Co-authored-by: sunghee-hwang <97494915+sunghee-hwang@users.noreply.github.com>
Uses same style as in the Audio Frame OBU.
|
I updated the notation based on feedback from the IAMF WG. It is just a style - not a bitstream change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAConfigurationRecord.- Future non-backwards compatible extensions will require
configurationVersionto be bumped.Preview | Diff