-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify CENC #827
Specify CENC #827
Conversation
Fix 820
@felicialim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The version of CENC reference is aligned with that of av1-isobmff.
- The restriction for encryption modes is removed. (to reflect WG's comment)
index.bs
Outdated
url: https://www.iso.org/standard/84637.html#; spec: CENC; type: dfn; | ||
text: cenc | ||
text: cbcs | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://www.iso.org/standard/84637.html#; spec: CENC; type: dfn; | |
text: cenc | |
text: cbcs |
Co-authored-by: sunghee-hwang <97494915+sunghee-hwang@users.noreply.github.com>
According to the ISOBMFF spec, (whole-block) full sample should be used for audio. I've added some text to clarify it, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1938,7 +1949,7 @@ NOTE: In a typical case, the OBUs in the first [=Descriptors=] of an [=IA Sequen | |||
A file conformant to this specification satisfies the following: | |||
- It SHALL conform to the normative requirements of [[!ISO-BMFF]]. | |||
- It SHALL have the <dfn export for="ISO-BMFF Brand">iamf</dfn> brand among the compatible brands array of the FileTypeBox. | |||
- It SHALL contain at least one track using an [=IASampleEntry=]. | |||
- It SHALL contain at least one track using an [=IASampleEntry=], possibly transformed by encryption as specified in [[#commonencryption]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking an "old" implementation of v1.0 could have assumed that files would never have encrypted IAMF tracks. I wonder if this warrants a new brand to signal the possible encryption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have box presence to signal CENC presence. We decided to not require new profiles to use CENC. If there are other examples of codecs that use brands to signal encryption presence we can do the same.
index.bs
Outdated
|
||
[=IA Track=]s MAY be protected. If protected, they SHALL conform to [[!CENC]]. | ||
|
||
When the protection schemes [=cenc=] or [=cbc1=] are used, an [=IA Track=] SHALL be protected using full sample encryption. When the protection schemes [=cens=] or [=cbcs=] are used, an [=IA Track=] SHALL be protected using whole-block full sample encryption. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of options, and therefore a lot of testing, and possible market fragmentation. Can't the group agree on one approach only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is CENC is mandatory in ISOBMFF, but CBCS is more widely used. We could pretty easily reduce it to two. Reducing it to one might be more difficult.
Fix #820
Preview | Diff