Fix #819, Base-Enhanced Profile #828
Conversation
sunghee-hwang
requested review from
tdaede,
cconcolato,
jwcullen,
felicialim and
Frank-Ba
index.bs
Outdated
| - They SHALL be able to reconstruct one [=Audio Element=]. | ||
| - They MAY use [=demixing_info_parameter_data=] or [=default_demixing_info_parameter_data=] to do down-mixing. | ||
| When the [=primary_profile=] field is set to 0, the following constraints apply to the [=IA Sequence=]: | ||
| - There SHALL be at least one [=Mix Presentation OBU=] that complies with the simple profile, in other words, a [=Mix Presentation OBU=] for only one [=Audio Element=] that parsers, which comply with the simple profile, recognize. |
There was a problem hiding this comment.
Since this Mix Presentation constraint applies to all Profiles, what do you think about moving it to the common restrictions above? As an example:
There SHALL be at least one Mix Presentation OBU that complies with the conformance points of the primary profile set in the IA Sequence.
index.bs
Outdated
| - They SHALL be able to parse an [=IA Sequence=] with [=primary_profile=] = 2. | ||
| - They SHALL be able to handle up to 28 channels. | ||
| - One example is a mix with 3rd-order Ambisonics (16 channels) + 7.1.4ch (12 channels). | ||
| - They SHALL be able to reconstruct twenty eight [=Audio Element=]s. |
There was a problem hiding this comment.
nit: "28" might be easier to read than "twenty eight"
| This section specifies the conformance points of the base-enhanced profile. | ||
|
|
||
| When the [=primary_profile=] field is set to 2, the following constraints apply to the [=IA Sequence=]: | ||
| - There SHALL be at least one [=Mix Presentation OBU=] for at most 28 [=Audio Element=]s that parsers, which comply with the base-enhanced profile, recognize. |
There was a problem hiding this comment.
To clarify the meaning of 28 channels or [=Audio Element=]s.
| - There SHALL be at least one [=Mix Presentation OBU=] for at most 28 [=Audio Element=]s that parsers, which comply with the base-enhanced profile, recognize. | |
| - There SHALL be at least one [=Mix Presentation OBU=] for at most 28 [=Audio Element=]s that parsers, which comply with the base-enhanced profile, recognize. | |
| - If [=additional_profile=] is set less than or equal to 2, there SHALL be at most 28 channels, the sum of channels across all [=Audio Element=]s in the [=IA Sequence=] that parsers, which comply with the base-enhanced profile, recognize. Otherwise, there MAY be more 28 channels or 28 [=Audio Element=]s in the [=IA Sequence=]. |
There was a problem hiding this comment.
I wanted to check my understanding.
Is the intention that if primary_profile = additional_profile = base-enhanced, then there is a max of 28 channels in the [=IA Sequence=]?
And if primary_profile = simple/base and additional_profile = base-enhanced, then there can be more than 28 channels in the [=IA Sequence=]?
There was a problem hiding this comment.
I wanted to check my understanding.
Is the intention that if
primary_profile = additional_profile = base-enhanced, then there is a max of 28 channels in the [=IA Sequence=]?
Yes, it isAnd if
primary_profile = simple/baseandadditional_profile = base-enhanced, then there can be more than 28 channels in the [=IA Sequence=]?
Yes, it can
There was a problem hiding this comment.
Sounds good. Just some minor editorial tweaks suggested below.
| - There SHALL be at least one [=Mix Presentation OBU=] for at most 28 [=Audio Element=]s that parsers, which comply with the base-enhanced profile, recognize. | |
| - There SHALL be at least one [=Mix Presentation OBU=] with at most 28 [=Audio Element=]s that parsers complying with the base-enhanced profile can recognize. | |
| - If [=additional_profile=] is set to less than or equal to 2, there SHALL be at most 28 channels in total across all [=Audio Element=]s in the [=IA Sequence=] that parsers complying with the base-enhanced profile can recognize. Otherwise, there MAY be more than 28 channels or 28 [=Audio Element=]s in the [=IA Sequence=].``` |
There was a problem hiding this comment.
It might be better to remove "can".
The Missed text for Base-Enhanced profile during merging PR #828
Preview | Diff