Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting track language during ISOBMFF encapsulation #833

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

felicialim
Copy link
Collaborator

@felicialim felicialim commented Jun 14, 2024

Fix #830


Preview | Diff

@felicialim felicialim changed the base branch from main to mixpresentationtags June 14, 2024 19:14
@felicialim
Copy link
Collaborator Author

This PR depends on changes introduced in #832 (specifically the ISO-639 reference)

Copy link
Collaborator

@sunghee-hwang sunghee-hwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdaede tdaede merged commit 6f226a2 into mixpresentationtags Jul 1, 2024
@sunghee-hwang sunghee-hwang deleted the isobmff-language branch July 2, 2024 02:34
sunghee-hwang added a commit that referenced this pull request Jul 29, 2024
It was missed during the merging of PR #833.
sunghee-hwang added a commit that referenced this pull request Aug 20, 2024
sunghee-hwang added a commit that referenced this pull request Aug 24, 2024
The missed properties during merging PR #833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to clarify how to declare the language code of IA Track with multiple languages
3 participants