Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To implement new layouts related to 9.1.6ch #834

Merged
merged 11 commits into from
Jul 1, 2024

Conversation

sunghee-hwang
Copy link
Collaborator

@sunghee-hwang sunghee-hwang commented Jun 18, 2024

Copy link
Collaborator

@felicialim felicialim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we use both "Center" channel and "Centre" channel in the spec - we should probably just stick to one spelling for consistency.

index.bs Outdated

For a given input [=3D audio signal=] with an expanded channel layout defined in [=expanded_loudspeaker_layout=], [=num_layers=] SHALL be set to 1 (i.e., it is a non-scalable channel audio element). Except [=9.1.6ch=] [=Audio Element=], it is RECOMMENDED to use such an [=Audio Element=] as an auxiliary [=Audio Element=] to be mixed with a primary [=Audio Element=] (e.g., TOA or 7.1.4ch) within a [=Mix Presentation=]. If parsers encounter a [=loudspeaker_layout=] = 15 for any layer other than the first layer, they SHOULD skip the [=channel_audio_layer_config=] for that layer and all subsequent layers.

Stereo (L/R) is shared with the stereo pair FLc/FRc, Stereo-RS (Lrs/Rrs) is shared with the stereo pair BL/BR, Stereo-TF (Ltf/Rtf) is shared with the stereo pair TpFL/TpFR, Stereo-TB (Ltb/Rtb) is shared with the stereo pair TpBL/TpBR and 3.0ch (L/C/R) is shared with FLc/FC/FRc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify what "shared with" means?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, for 9.1.6ch + FLc/FRc, the actual signaling would be 9.1.6ch + L/R.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. WDYT about making it more explicit with something like "The following channel layouts may additionally be indicated using an existing loudspeaker_layout or expanded_loudspeaker_layout. The stereo pair FLc/FRc is indicated using Stereo (L/R)."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
sunghee-hwang and others added 2 commits June 19, 2024 08:36
Co-authored-by: Felicia Lim <flim@google.com>
Co-authored-by: Felicia Lim <flim@google.com>
@sunghee-hwang
Copy link
Collaborator Author

nit: we use both "Center" channel and "Centre" channel in the spec - we should probably just stick to one spelling for consistency.

Let's handle it with the other editorial updates.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@sunghee-hwang
Copy link
Collaborator Author

[Question] How do you feel adding the Top-6ch of 9.1.6ch?
As we agreed on having the Top-4ch of 7.1.4ch, it makes sense to have the Top-6ch of 9.1.6ch.

@felicialim
Copy link
Collaborator

[Question] How do you feel adding the Top-6ch of 9.1.6ch? As we agreed on having the Top-4ch of 7.1.4ch, it makes sense to have the Top-6ch of 9.1.6ch.

This makes sense.

index.bs Outdated Show resolved Hide resolved
@jingbo-marquis
Copy link

4.3. IA Base-Enhanced Profile
They SHALL be able to handle up to 28 channels.

The 28 channels limit applies to the sum of channels across all [Audio Element ]s in a [Mix Presentation ])before mixing.
One example is a mix with 3rd-order Ambisonics (16 channels) + 7.1.4ch (12 channels).

if 9.1.6 layout is added as input layout , the max channels in a mix should be 32 which 16 channel is for 3rd-order Ambisonics and 16 channels are for 9.1.6

@sunghee-hwang
Copy link
Collaborator Author

4.3. IA Base-Enhanced Profile They SHALL be able to handle up to 28 channels.

The 28 channels limit applies to the sum of channels across all [Audio Element ]s in a [Mix Presentation ])before mixing.
One example is a mix with 3rd-order Ambisonics (16 channels) + 7.1.4ch (12 channels).

if 9.1.6 layout is added as input layout , the max channels in a mix should be 32 which 16 channel is for 3rd-order Ambisonics and 16 channels are for 9.1.6

You are right. But as our latest consensus limits the sum of channels up to 28, it does not allow the mix of TOA and 9.1.6ch.

index.bs Outdated Show resolved Hide resolved
@tdaede tdaede merged commit d79b577 into main Jul 1, 2024
@sunghee-hwang sunghee-hwang deleted the expanded-loudspeaker-layout-b branch July 2, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants