Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standalone clang from PATH #2202

Conversation

wantehchang
Copy link
Collaborator

Use the clang in Visual Studio. Recommended in
actions/runner-images#10001 (comment).

@wantehchang wantehchang force-pushed the ci-windows-really-use-vs-clang-cl branch from ab6f83e to 3a81344 Compare June 11, 2024 18:45
@wantehchang
Copy link
Collaborator Author

@vrabaud Vincent: I can't reproduce the avifcodectest failure on my Windows laptop. I use the clang-cl in Visual Studio, and this pull request emulates my setup. The only difference is that I disable the rav1e codec (because I don't have Rust installed).

@vrabaud
Copy link
Collaborator

vrabaud commented Jun 11, 2024

We can also wait for clang 18 to be in by default but your solution is more futureproof so LGTM

Use the clang in Visual Studio. Recommended in
actions/runner-images#10001 (comment).
@wantehchang wantehchang force-pushed the ci-windows-really-use-vs-clang-cl branch from f9a191c to 58f965d Compare June 11, 2024 23:30
@wantehchang
Copy link
Collaborator Author

I abandoned this pull request. After 02816a3, we are not compiling libaom with clang-cl. Although we are still compiling libyuv with clang-cl, libyuv doesn't use the C++ STL. (libyuv is essentially C code compiled with C++ compilers.) So we no longer need this workaround.

Although it is arguably safer to use the clang bundled with Visual Studio, I think it is good to test libavif with a standalone installation of clang.

@wantehchang wantehchang deleted the ci-windows-really-use-vs-clang-cl branch June 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants