fix: add JSONSchema7 types, resolve option index signature & missing JSONSchema return type in resolver options read
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing `JSONSchema` return type in resolver options `read`
|
Hi, any traction on this? I'm trying to use this with the output from ts-json-schema-generator, and that outputs JSONSchema7 |
philsturgeon
approved these changes
May 6, 2021
philsturgeon
approved these changes
May 6, 2021
|
shall i do something? edit: it seems tests don't run |
|
I'm not sure what the hell is going on here @medfreeman sorry! I've been trying to get tests running for a little while but its not going anywhere. |
|
Aha! Got it. When #233 is merged please update your branch. |
|
🎉 This PR is included in version 9.0.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224