Skip to content

Commit

Permalink
fix: ci and coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
jonluca committed Oct 10, 2024
1 parent 447f9ad commit d10b109
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/CI-CD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ jobs:
- macos-latest
- windows-latest
node:
- 16
# - 18 TODO bring this back
- 20

steps:
- name: Checkout source
Expand Down Expand Up @@ -71,7 +70,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: lts
node-version: 20
cache: "npm"

- name: Install dependencies
Expand Down Expand Up @@ -122,7 +121,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: lts
node-version: 20
cache: "npm"

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:browser": "karma start --single-run",
"test:typescript": "tsc --noEmit --strict --lib esnext,dom test/specs/typescript-definition.spec.ts",
"coverage": "npm run coverage:node && npm run coverage:browser",
"coverage:node": "nyc node_modules/mocha/bin/mocha",
"coverage:node": "QUICK_TEST=true nyc mocha",
"coverage:browser": "npm run test:browser -- --coverage",
"upgrade": "npm-check -u && npm audit fix",
"bump": "bump --tag --push --all",
Expand Down
2 changes: 1 addition & 1 deletion test/specs/real-world/real-world.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const knownErrors = require("./known-errors");
const fetchApiList = require("./fetch-api-list");

// How many APIs to test in "quick mode" and normal mode
const MAX_APIS_TO_TEST = (host.node && process.argv.includes("--quick-test")) ? 10 : 1000;
const MAX_APIS_TO_TEST = (host.node && process.argv.includes("--quick-test") || process.env.QUICK_TEST) ? 10 : 1000;
const START_AT_INDEX = 0;
const MAX_DOWNLOAD_RETRIES = 3;

Expand Down

0 comments on commit d10b109

Please sign in to comment.