fix: bump dependencies, fix tests, fix imports from deps #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
approved these changes
Oct 11, 2024
kibertoad
approved these changes
Oct 11, 2024
|
Thank you! |
Yeah I removed the browser tests. I was thinking of just moving over to testing with vitest and jsdom. It won't be as comprehensive but the web is a lot more standardized now than it was when the package was originally published, and I doubt web usage is all that high anyways. I think its a worthwhile tradeoff to make for now. |
|
gotcha, thanks. we need to remove the check then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix CI and also fix the issues with the latest version of json-schema-ref-parser.
I'm inclined to release this as a breaking change, since theres a lot of internals that changed in the TS rewrite
BREAKING CHANGE: Upgrade dependencies, refactor test runner, fix implementation based on new version of json schema ref parser