Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine 2.6.1 compatibility #1001

Closed
cyrilprevot opened this issue Mar 12, 2018 · 8 comments
Closed

Doctrine 2.6.1 compatibility #1001

cyrilprevot opened this issue Mar 12, 2018 · 8 comments

Comments

@cyrilprevot
Copy link

I got "Error: Expected Doctrine\ORM\Query\Lexer::T_FROM, got ':'" since 2.6.1 doctrine update.
The issue seem to be due to new DQL parsing.
":" can't be use anymore in select clause and the bundle add "::" between subentity and field. Futhermore, function in Grid\Source annotation doesn't work anymore (field:count) cause of ":"

@DonCallisto
Copy link
Member

Duplicate of #772

@DonCallisto DonCallisto marked this as a duplicate of #772 Mar 12, 2018
@DonCallisto
Copy link
Member

@cyrilprevot take a look to the issue marked as duplicate and try what I've said there to check if the problem is gone.

I would appreciate a feedback from you.
Thanks.

@DonCallisto
Copy link
Member

I've drafted a new release for this https://github.com/APY/APYDataGridBundle/releases/tag/3.1.2

@pavelmitko
Copy link

Hello @DonCallisto ,
The issue is not fixed. You have forgot about DQL functions!

@GRID\Column(field="id:count")
will be replaced as SELECT count(_tableAlias.id) AS id:count what will raise an error:
Doctrine\ORM\Query\QueryException : [Syntax Error] line 0, col 1142: Error: Expected Doctrine\ORM\Query\Lexer::T_IDENTIFIER, got 'id:count'

Grid/Source/Entity.php:222 -> $alias = $this->fromColIdToAlias($name); // helped. please investigate

@DonCallisto
Copy link
Member

I'll take a look at this ASAP.
Thanks.

@DonCallisto
Copy link
Member

@pavelmitko could you require this branch in composer.json and check if the issue go away?
https://github.com/APY/APYDataGridBundle/tree/Fix_DQL_Annotation

If so, I will merge it in master and release another bugfix version.

Let me know, thank you.

@ruprai
Copy link

ruprai commented Jul 2, 2019

Hi @DonCallisto. I have tried the branch. The correction appears to have fixed the issue.

@DonCallisto
Copy link
Member

@ruprai thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants