-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/PHP8 #1068
Feature/PHP8 #1068
Conversation
@npotier this user did get the hook working |
Looks good. Any progress on getting PHP 8.x compatibility? I recently upgraded another project (that is not using this bundle) and was gonna tackle my project that is using this bundle next. |
Hello, updates from this MR: I have rewritten all the tests in order to make them works with new version of PHPUnit. I will release this version as a |
OK. It is merged on |
Work in Progress
The code has been refactored using rector. PHPUnit has been upgraded, and the tests has been partially rewritten in order to comply with this new version.
Test are failing when some MongoDB classes declared as final are mocked:
example :
I've tried to use https://github.com/dg/bypass-finals, but without success.
if you have any idea on how to bypass this issue, feel free to tell it here. Otherwise, it might be necessary to rewrite the logic of the test.