Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Output walkers of Entity with joins (Fixes #931) #946

Merged
merged 1 commit into from
May 17, 2017

Conversation

StudioMaX
Copy link
Contributor

Fix for issue #931
There is another pull request #939 , but it will revert the functionality added by commit #828

@DonCallisto
Copy link
Member

@hmert I've seen you merged #828. Can you take a look to this?

@Vowow
Copy link

Vowow commented May 17, 2017

Please merge this one

@DonCallisto
Copy link
Member

@Vowow Waiting for maintainer of the bundle to check if everything it's ok. I can merge it too but I'm not into all bundle logic and, without test cases, I can't judge if this is good or not.
However I would expected more commitment from new maintainers .... /cc @hmert

@hmert
Copy link
Contributor

hmert commented May 17, 2017

@DonCallisto and @Vowow I could not figure out why we're removing walkers. But, in our project. I've tested this PR it looks OK.

@DonCallisto
Copy link
Member

@StudioMaX can you explain this change to @hmert ?

@Vowow
Copy link

Vowow commented May 17, 2017

@hmert This provide a fix to a bug when you add a manyToOne column to the grid with annotation.
The error is : "The Paginator does not support Queries which only yield ScalarResults. "

@hmert hmert merged commit d2c4f76 into APY:master May 17, 2017
@StudioMaX
Copy link
Contributor Author

@hmert can you release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants