Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with unformat gui slot #41

Closed
Fusezion opened this issue Jul 22, 2021 · 2 comments
Closed

Issue with unformat gui slot #41

Fusezion opened this issue Jul 22, 2021 · 2 comments
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Jul 22, 2021

Description

So while using Skript-GUI I tend to use (integers from 0 to 53) and loop x times
this allows me to do large changes with a smaller amount of code and looks neater
however, I've noticed that whenever I use unformat gui slot (integers from 10 to 16) or loop {_value} times:
it only ever loops once and then seems to cut off anything else in the gui creation

Steps to Reproduce

simply add this code into a test server and run the /example command if it's anything like mine it
should open the GUI and have all GUI slots filled with black glass pane with only slot 0 being air

command /example:
	trigger:
		create a gui with virtual chest inventory with 3 rows named "":
			format gui slot (integers from 0 to 26) with black glass pane named " "
			loop 9 times:
				unformat gui slot (loop-value)-1
			unformat gui slot (integers from 9 to 17) # nothing changes when I use `slots`
			unformat gui slot 18,19,20,21,22,23,24,25 and 26
			format next gui slot with stone
		open last gui to player

Expected Behavior

I'd expect to see a gui slots air besides slot 0 being stone

Errors / Screenshots

image
this image here is an old screenshot prior to me changing the skript originally it only unformated slots (10 to 16)
however, while I was testing I noticed it did the same with unformat gui slot 10, 11, 12, ect

Server Information

  • Server version/platform: Java, Paper Latest (1.16.5)
  • skript-gui version: Skript-Gui, 1.2.2
  • Skript version: Skript, 2.5.3

Additional Context

I've never had this issue in the past when using TuSKe so I do believe it's a bug

@Fusezion Fusezion added the bug Something isn't working label Jul 22, 2021
@Fusezion Fusezion changed the title Issue with unformat gui slot when using loops Issue with unformat gui slot Jul 22, 2021
@APickledWalrus
Copy link
Owner

I will take a look into this issue when I next get the chance :) (should be pretty soon)

@APickledWalrus
Copy link
Owner

I couldn't exactly replicate your issue using the alpha nightly builds, but I did notice it wasn't exactly working as expected. With the latest commit above merged, I believe this issue has been fixed. Here's what it looks like now:
image

@APickledWalrus APickledWalrus added the completed Bug fix / enhancement will be available in the next release label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release
Projects
None yet
Development

No branches or pull requests

2 participants