QC Updates #675
Merged
QC Updates #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing now is what I would have assumed would be the closed reported station.
…file to add to the history attribute
|
I really am not sure where all the commits come from in here. I just opened this branch and started working on this today. |
zssherman
reviewed
May 23, 2023
zssherman
reviewed
May 23, 2023
|
A couple comments, one change possibly. Tests seem to fail as rm_tests is an int object. Should it be i in range(rm tests) or is rm_tests going to be a list datafilter changes? |
|
Looks likes some updates with MetPy calcs so will handle in the morning |
|
@zssherman I fixed the bug for when rm_tests is a single int. I change it to a list and then iterate through. |
mgrover1
approved these changes
May 23, 2023
|
@zssherman if I addressed your comments go ahead and merge this on in! If not, let me know. |
|
Sounds good @AdamTheisen, once the tests pass I'll merge away! |
|
Rerunning jobs as they seemed to be hung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #547 and #548 but came across an issue in the write_netcdf function that causes issues with ARM's base_time string attribute.