refactor: changing to allow user to pass layout of mosaic subplots ex… #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicitly as a keyword argument
|
@cgodine More I thought about it, can we set the default to stay constrained, with the docstring stating that. But still keep the ability for the user to define what they want? |
Yeah, I think with the way testing is set up that might be an easier fix. |
zssherman
approved these changes
May 23, 2023
|
@cgodine Thanks for making the changes, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plicitly as a keyword argument.
Change will give user more flexibility on how the enhanced skew-t subplots are laid out on the image.