Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Bug fix. The flag_masks are bits and the test is the test numbe… #695

Merged
merged 2 commits into from
Jul 1, 2023
Merged

BUG: Bug fix. The flag_masks are bits and the test is the test numbe… #695

merged 2 commits into from
Jul 1, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Jul 1, 2023 •
edited
Loading

…r so we need to do the conversion

  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@zssherman
Copy link
Collaborator

@AdamTheisen Changes look good, just the operator needs a pep8 fix.

@zssherman
Copy link
Collaborator

@AdamTheisen I pushed the PEP8 fix

@AdamTheisen AdamTheisen merged commit dd8b74c into ARM-DOE:main Jul 1, 2023
@AdamTheisen AdamTheisen deleted the qc_history branch July 1, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamTheisen @zssherman